Add file-content launch substitution #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This substitution implements a portable mechanism to read the contents of a file on disk. This procedure is used in various scenarios throughout ROS 2, and currently relies on `exec` and `command` substitutions to read files. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
mjcarroll
reviewed
May 16, 2023
mjcarroll
approved these changes
May 16, 2023
3 tasks
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 31, 2023
This substitution implements a portable mechanism to read the contents of a file on disk. This procedure is used in various scenarios throughout ROS 2, and currently relies on `exec` and `command` substitutions to read files. Signed-off-by: Scott K Logan <logans@cottsay.net> (cherry picked from commit 913eae2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This substitution implements a portable mechanism to read the contents of a file on disk. This procedure is used in various scenarios throughout ROS 2, and currently relies on
execandcommandsubstitutions to read files.I'm particularly interested in review of the substitution name.
Reference implementation: ros2/demos#627
Closes #707