-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatitibility with pytest 7 #592
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good solution to me. Approved with green CI on Focal Linux, Jammy Linux, and Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@clalancette I see 16 warnings and 1 test failure in sros2 on Jammy, but none of them seem related to this PR. Do you know of a job with the current state of Jammy that I can compare this CI run to? |
Those are all expected as of right now. The 16 warnings are from use of older OpenSSL APIs in Fast-DDS (I need to open an issue for that). The failing mypy test should be fixed by ros2/ci#617 (I still need to do a bit more testing there). So this looks good to merge to me! |
@Mergifyio backport foxy galactic |
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 13d0c28)
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> (cherry picked from commit 13d0c28)
✅ Backports have been created
|
1 similar comment
✅ Backports have been created
|
fixes #590
This adds a new function _pytest_version_ge to make the hooks compatible with multiple versions of pytest. I tested that
rclpy
andlaunch_testing
's tests passed on my system with pytest versions4.6.9
,5.4
,6.0
, and7.0
.In short, pytest deprecated the uses of their
LocalPath
class in favor ofpathlib.Path
.Tested using commands like: