Stop using python_cmake_module. #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
6cf7ca5
to
45f921f
Compare
scpeters
approved these changes
Mar 22, 2024
adityapande-1995
approved these changes
Mar 22, 2024
fujitatomoya
approved these changes
Mar 22, 2024
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
45f921f
to
155e537
Compare
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
2 times, most recently
from
753c3dd
to
c993c35
Compare
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
c993c35
to
1aed5ef
Compare
We really don't need it anymore, and can just use the builtin find_package(Python3). Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
1aed5ef
to
7edadb6
Compare
|
CI for this (along with all of the rest of the changes needed) is in ros2/ros2#1524 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really don't need it anymore, and can just use the builtin find_package(Python3).
This must be merged before ros2/ros2#1524 ; see that pull request for more information about this change.