Increase test_composable_node_container timeout #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing
|
|
This is likely due to ros2/rmw_connext#325 |
brawner
approved these changes
Oct 28, 2020
Yeah, you're right. I had it backwards. I'll clarify in the commit message. |
Resolves #184. With some RMW implementations, like rmw_connext_cpp, it takes a bit longer to initialize or shutdown ROS nodes. Related issue: ros2/rmw_connext#325 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/extend_test_timeout
branch
from
048f136
to
725f939
Compare
jacobperron
added a commit
that referenced
this pull request
Nov 20, 2020
Resolves #184. With some RMW implementations, like rmw_connext_cpp, it takes a bit longer to initialize or shutdown ROS nodes. Related issue: ros2/rmw_connext#325 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #184.
With some RMW implementations, like rmw_connext_cpp, it takes a bit longer to start ROS nodes.