Use wildcard syntax in generated parameter YAML files #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
jacobperron
reviewed
Jun 18, 2019
This will eliminate the requirement that a node name override be specified when passing a dictionary of parameters from launch. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
wildcard_param_yaml
branch
from
df896f1
to
627a8da
Compare
jacobperron
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eliminate the requirement that a node name override be specified when passing a dictionary of parameters from launch.
Requires ros2/rclcpp#762
Requires ros2/rclpy#370
Resolves #4