Fix comparison of different time sources in C++ TimeSequencer #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to issues #21 and #175
Currently, the C++ implementation of the TimeSequencer is not working, as the following error is thrown:
The proposed fix implements the suggested solutions from the issues and initializes
last_time_
in the constructor to use the clock typeRCL_ROS_TIME
. This is necessary because the message time stamp(here) is returned with clock type
RCL_ROS_TIME
and comparing two different clock types is not allowed. The clock type in its corresponding test files is also changed.Additionally, the timer
update_timer_
is created using the node's clock instead of the wall clock to also work in simulation with sim-time.Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
Tested under ROS2 Jazzy and ROS2 Rolling.