Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build on Noble #47

Merged
merged 2 commits into from
May 27, 2024
Merged

Fix the build on Noble #47

merged 2 commits into from
May 27, 2024

Conversation

clalancette
Copy link

There are 3 fixes in here:

  1. Make sure to #include <cstdint> as necessary.
  2. Switch to using rosidl_get_typesupport_target, which is our modern way of doing things.
  3. Make sure to move lock initialization before m_com initialization to resolve a warning.

This should fix #46

@clalancette clalancette changed the base branch from master to run_on_buildfarm May 24, 2024 12:44
@clalancette
Make sure to #include <cstdint> in qos_abstraction.hpp
731a684 
Since it depends on it.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Move lock initialization before m_com initialization.
629d3d8 
The latter depends on the former.  This resolves a warning
when building with modern GCC.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette force-pushed the clalancette/fix-build-on-noble branch from 4d95445 to 629d3d8 Compare May 24, 2024 12:46
@clalancette
Copy link
Author

CI for this is in https://build.ros2.org/view/Rci/job/Rci__nightly-performance_ubuntu_noble_amd64/26/

@clalancette clalancette merged commit be9c217 into run_on_buildfarm May 27, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/fix-build-on-noble branch May 27, 2024 21:30
@Crola1702 Crola1702 mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 Rolling and Jazzy performance jobs failing
2 participants
@clalancette @ahcorde