Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rcl count clients, servicec & tests #1011

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Add rcl count clients, servicec & tests #1011

merged 2 commits into from
Oct 5, 2023

Conversation

leeminju531
Copy link
Contributor

this PR is for service counts using it's name like topic.
Related to ros2/ros2cli#771

Signed-off-by: leeminju531 dlalswn531@naver.com

@leeminju531 leeminju531 marked this pull request as draft October 8, 2022 14:16
@leeminju531 leeminju531 marked this pull request as ready for review October 8, 2022 14:26
@leeminju531 leeminju531 marked this pull request as draft October 17, 2022 01:00
@leeminju531 leeminju531 marked this pull request as ready for review December 12, 2022 02:15
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me with green CI.

rcl/include/rcl/graph.h Outdated Show resolved Hide resolved
rcl/include/rcl/graph.h Outdated Show resolved Hide resolved
rcl/include/rcl/graph.h Outdated Show resolved Hide resolved
rcl/include/rcl/graph.h Outdated Show resolved Hide resolved
rcl/include/rcl/graph.h Outdated Show resolved Hide resolved
rcl/include/rcl/graph.h Outdated Show resolved Hide resolved
rcl/include/rcl/graph.h Outdated Show resolved Hide resolved
rcl/include/rcl/graph.h Outdated Show resolved Hide resolved
rcl/test/rcl/test_graph.cpp Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator

only minor doc section update is required, @leeminju531 can you address those?

Signed-off-by: leeminju531 <dlalswn531@naver.com>
Signed-off-by: leeminju531 <dlalswn531@naver.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to me, I'll run CI just on this one.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 8f7f4f0 into ros2:rolling Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants