Avoid dynamic allocation of message before sending over rosout #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested changes
May 8, 2023
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
Done: cpplint and uncrustify are happy now. |
clalancette
approved these changes
May 12, 2023
|
CI:
|
Acuadros95
pushed a commit
to micro-ROS/rcl
that referenced
this pull request
Jun 6, 2023
…1067) Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
Acuadros95
pushed a commit
to micro-ROS/rcl
that referenced
this pull request
Jun 6, 2023
…1067) Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
danthony06
pushed a commit
to danthony06/rcl
that referenced
this pull request
Jun 14, 2023
…1067) Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an approach for filling the messages send over rosout without involving additional heap allocations. I might miss something here, but for me this approach seems more reasonable - at least regard performance.