Cleanup the error handling in rcl_node_init.

[clalancette]

Only undo things that we've done before. Not only does this result in less code, it also avoids spurious warnings from trying to cleanup things that we haven't initialized.

[fujitatomoya]

having the inverted water fall order to finalize with goto statement works and do only necessary finalization. on the other hand, it would be complicated to add the process afterwards not to miss the correct jump point for code maintenance. (this could easily go to memory leak issue.)

i would prefer the single failing jump point and check if what is necessary to call with current implementation.

[clalancette]

i would prefer the single failing jump point and check if what is necessary to call with current implementation.

That's fair. While this definitely cleans some things up, maybe it isn't the best strategy (even if I find it to be the easiest to understand). Let me try something else here.

[clalancette]

All right, I've totally revamped this to go another direction. In particular, I keep the fail handling as it was, but just make it a lot more careful about only undoing things that have already been done. I think this turns out pretty nice, should still remove some of the bogus warning messages we get, and still removes a bunch of code. Please take another look when you get a chance!

[clalancette]

CI:

• Linux
• Linux-aarch64
• Windows

[fujitatomoya]

CI(retry):

• Linux-aarch64