Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --log-file-name to ros args. #1127

Merged

Conversation

fujitatomoya
Copy link
Collaborator

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@iuhilnehc-ynos requesting review.

@iuhilnehc-ynos
Copy link
Collaborator

I have a question, do most people think python3_pid_ts.log is a normal log file name? If yes, I think we can add an extra argument to generate a custom prefix name for log file, otherwise the python3 should be replaced with another name. (e.g. the filename of __main__).

I am not sure if users would like to add this argument for most python executable in a launch file.

@fujitatomoya
Copy link
Collaborator Author

otherwise the python3 should be replaced with another name. (e.g. the filename of main).

yeah we can do that. maybe we can discuss on what could be default name when we get an executable name with python3. but here we just give the capability for user to change the log name as they like. i thought that can be more flexible for user. thanks for the review.

@fujitatomoya
Copy link
Collaborator Author

Note: Rpr job is supposed to fail since it does not include ros2/rcl_logging#109

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit f8af11f into ros2:rolling Jan 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants