Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order rcl_logging_interface include #1133

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Feb 29, 2024

We're not very strict about includes, but I noticed a slight divergence as a result of #676

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me, though as you say we don't truly have a defined style here.

@clalancette
Copy link
Contributor

Given that this is just updating the style, I'm going to go ahead and merge with the Rpr job passing green.

@clalancette clalancette merged commit 061f546 into ros2:rolling Feb 29, 2024
3 checks passed
@christophebedard christophebedard deleted the christophebedard/reorder-rcl-logging-interface-include branch February 29, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants