Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate version header using ament_generate_version_header(..) #1141

Merged
merged 1 commit into from Mar 28, 2024
Merged

Generate version header using ament_generate_version_header(..) #1141

merged 1 commit into from Mar 28, 2024

Conversation

gavanderhoorn
Copy link
Contributor

Would fix #1139.

@gavanderhoorn gavanderhoorn force-pushed the add_ament_generate_version_header branch from 8f4294f to 4988b3c Compare March 26, 2024 08:51
@gavanderhoorn
Copy link
Contributor Author

I'm pretty sure the test failures are unrelated to the changes in this PR.

@gavanderhoorn
Copy link
Contributor Author

A similar PR on rcpputils: ros2/rcpputils#190.

fujitatomoya
fujitatomoya approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gavanderhoorn
Copy link
Contributor Author

I noticed ros2/rcpputils#190 adds a buildtool_depend on ament_cmake_gen_version_h.

Is that necessary? Or does the already present ament_cmake take care of that?

@clalancette
Copy link
Contributor

Is that necessary? Or does the already present ament_cmake take care of that?

It's necessary; it is a separate package.

@gavanderhoorn gavanderhoorn force-pushed the add_ament_generate_version_header branch from 4988b3c to f75fef6 Compare March 26, 2024 17:18
@gavanderhoorn
Copy link
Contributor Author

Fixed.

@gavanderhoorn
Copy link
Contributor Author

Friendly ping.

@gavanderhoorn
Generate version header using ament_generate_version_header(..)
4fb3a4f 
Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
@gavanderhoorn gavanderhoorn force-pushed the add_ament_generate_version_header branch from f75fef6 to 4fb3a4f Compare March 28, 2024 08:06
@gavanderhoorn
Copy link
Contributor Author

Realised I forgot to find_package(ament_cmake_gen_version_h).

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 5766d5e into ros2:rolling Mar 28, 2024
2 of 3 checks passed
@gavanderhoorn gavanderhoorn deleted the add_ament_generate_version_header branch March 29, 2024 15:42
@gavanderhoorn
Copy link
Contributor Author

Thanks for the review(s) and merging this @fujitatomoya.

Would there be any way this could be backported to Humble and Iron?

IIUC, ament_cmake_gen_version_h is available there as well.

@fujitatomoya
Copy link
Collaborator

@Mergifyio barkport iron humble

@mergify Mergify
Copy link

mergify bot commented Mar 30, 2024

barkport iron humble

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@fujitatomoya
Copy link
Collaborator

@Mergifyio backport iron humble

@mergify Mergify
Copy link

mergify bot commented Mar 30, 2024 •
edited

backport iron humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 30, 2024
@gavanderhoorn @mergify
Generate version header using ament_generate_version_header(..) (#1141)
8c8e9bd 
Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit 5766d5e)

# Conflicts:
#	rcl_action/CMakeLists.txt
#	rcl_lifecycle/CMakeLists.txt
@mergify mergify bot mentioned this pull request Mar 30, 2024
Open
mergify bot pushed a commit that referenced this pull request Mar 30, 2024
@gavanderhoorn @mergify
Generate version header using ament_generate_version_header(..) (#1141)
bdcc4c2 
Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit 5766d5e)

# Conflicts:
#	rcl/CMakeLists.txt
#	rcl_action/CMakeLists.txt
#	rcl_lifecycle/CMakeLists.txt
#	rcl_yaml_param_parser/CMakeLists.txt
@mergify mergify bot mentioned this pull request Mar 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding ament_generate_version_header(..) to these packages?
4 participants
@gavanderhoorn @clalancette @fujitatomoya @mjcarroll