Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return number in types.h #71

Closed
firesurfer opened this issue Aug 21, 2016 · 2 comments
Closed

Wrong return number in types.h #71

firesurfer opened this issue Aug 21, 2016 · 2 comments
Labels
bug Something isn't working

Comments

@firesurfer
Copy link
Contributor

I read some code for my C# wrapper and found these lines in the rcl types.h:

// rcl subscription specific ret codes in 4XX
#define RCL_RET_SUBSCRIPTION_INVALID 400
#define RCL_RET_SUBSCRIPTION_TAKE_FAILED 501
// rcl service client specific ret codes in 5XX
#define RCL_RET_CLIENT_INVALID 500
#define RCL_RET_CLIENT_TAKE_FAILED 501

Shouldn't be #define RCL_RET_SUBSCRIPTION_TAKE_FAILED 501 defined to 401 instead of 501 ?

@dirk-thomas
Copy link
Member

That looks indeed like a copy-n-paste error. Can you please create a PR to address it?

@dirk-thomas
Copy link
Member

Fixed by #72.

emersonknapp pushed a commit to aws-ros-dev/rcl that referenced this issue Jun 3, 2019
* use RCUTILS_SAFE_FWRITE_TO_STDERR

* use macro in allocator.c as well
ivanpauno pushed a commit that referenced this issue Jan 2, 2020
update compiler check to match AppleClang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants