Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iron]Add ~/get_type_description service (rep2011) (backport #1052) #1082

Merged
merged 3 commits into from Jul 18, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 6, 2023

This is an automatic backport of pull request #1052 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add ~/get_type_description service API
* Add node type cache
* Register subscription, publication, service and action types with node type cache
* Add functions to convert between rosidl_runtime_c / type_description_interfaces structs

RCL does not initialize the get_type_description service itself, instead providing a full enough API for full language clients to initialize it and register its callback within their threading/execution framework

Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>

(cherry picked from commit a4633b8)
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Collaborator

emersonknapp commented Jul 6, 2023

Pulls: #1082
Gist: https://gist.githubusercontent.com/emersonknapp/61d26c17c20db2ffe486cf46d9e231a2/raw/d68aba806afdee3687a31ae2557b6d40f77ecbe2/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rcl_action
TEST args: --packages-above rcl rcl_action
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12335

  • Linux Build Status
    • Build Status
    • Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left just one comment to think about. This otherwise looks good to me.

rcl/src/rcl/node_options.c Outdated Show resolved Hide resolved
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Collaborator

emersonknapp commented Jul 17, 2023

@emersonknapp emersonknapp changed the title Add ~/get_type_description service (rep2011) (backport #1052) [Iron]Add ~/get_type_description service (rep2011) (backport #1052) Jul 17, 2023
@clalancette clalancette merged commit 3db75e5 into iron Jul 18, 2023
3 checks passed
@clalancette clalancette deleted the mergify/bp/iron/pr-1052 branch July 18, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants