Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy backport] Tweaks to client.c and subscription.c for cleaner init/fini (#728) #822

Merged
merged 1 commit into from
Oct 5, 2020
Merged

[foxy backport] Tweaks to client.c and subscription.c for cleaner init/fini (#728) #822

merged 1 commit into from
Oct 5, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Oct 5, 2020

This backports #728 for rcl

Signed-off-by: Stephen Brawner brawner@gmail.com

@brawner
Tweaks to client.c and subscription.c for cleaner init/fini (#728)
2dbb1c9 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented Oct 5, 2020

Testing --packages-select rcl

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner brawner changed the title Tweaks to client.c and subscription.c for cleaner init/fini (#728) [foxy backport] Tweaks to client.c and subscription.c for cleaner init/fini (#728) Oct 5, 2020
@brawner
Copy link
Contributor Author

brawner commented Oct 5, 2020

All tests pass except for test_wait on windows, which looks more like a flaky test than something related to this PR, since this is just setting pointers to null on finalization.

@brawner brawner merged commit 6a137f1 into foxy Oct 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/rcl-backport-728 branch October 5, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brawner @jacobperron