Mark blacklisted tests as skipped #90
Conversation
| LIBRARIES ${PROJECT_NAME}${target_suffix} ${extra_test_libraries} | ||
| AMENT_DEPENDENCIES ${rmw_implementation} "example_interfaces" "std_msgs" | ||
| SKIP_TEST | ||
| ) |
There was a problem hiding this comment.
Instead of duplicating the function call with all its arguments I would suggest to use a variable to either pass or not pass SKIP_TEST.
| if(_ARG_SKIP_TEST) | ||
| set(_ARG_SKIP_TEST "SKIP_TEST") | ||
| else() | ||
| set(_ARG_SKIP_TEST "") |
There was a problem hiding this comment.
I don't think this is necessary? The variable should be unset / empty.
There was a problem hiding this comment.
for some reason before adding this, "FALSE" was passed to the script instead of an empty string, resulting in the following error: run_test.py: error: --env argument 'FALSE' contains no equal sign
haven't found why FALSE is passed yet
There was a problem hiding this comment.
Hm, I see. Looks like cmake_parse_arguments is actually setting it to either TRUE or FALSE. I thought that was different some (probably long) time ago. Sounds good as it is then. Sorry for the noise.
* expose list of nodes * review comments * extend year of copyright
No description provided.