Add test dependencies for rclc_parameter #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
Both of these packages are included in the BUILD_TESTING section of the CMakeLists.txt but not represented in package.xml. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
nuclearsandwich
force-pushed
the
nuclearsandwich/test-depends
branch
from
5c2e9a5
to
9d8f21a
Compare
JanStaschulat
approved these changes
Jul 26, 2021
|
@nuclearsandwich Thank you very much for fixing this. I could not understand, why the build job at ROS 2 build farm passed successfully, but the bloom release did not. Thanks for the explanation. |
|
Fixes #133 |
|
@mergify backport galactic |
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Trim trailing whitespace. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Add test dependency on osrf_testing_tools_cpp. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Add additional test dependencies. Both of these packages are included in the BUILD_TESTING section of the CMakeLists.txt but not represented in package.xml. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> (cherry picked from commit 705efff)
|
Command
Hey, I reacted but my real name is @Mergifyio |
JanStaschulat
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Trim trailing whitespace. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Add test dependency on osrf_testing_tools_cpp. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Add additional test dependencies. Both of these packages are included in the BUILD_TESTING section of the CMakeLists.txt but not represented in package.xml. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> (cherry picked from commit 705efff) Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
This was referenced Jul 26, 2021
Create bloom release for Galactic and Rolling to resolve test dependencies in 'rclc_parameters'
#160
Closed
|
Created new bloom release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While auditing Rolling build farm failures I saw that rclc_parameter has not yet built successfully.
From the build log there appears to be an undeclared dependency on
osrf_testing_tools_cpp.Examining the cmake config I also saw dependencies on
std_msgsandexample_interfaceswhich I added in a later commit.It's likely that this hasn't shown up in CI since all rclc packages are built together in the same workspace and so can share dependencies but since the deb packages are built independently we first see these issues there.