refactor #116 remove callback_type (backport #154) #163

mergify · 2021-07-28T10:06:57Z

This is an automatic backport of pull request #154 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

@Mergifyio refresh will re-evaluate the rules
@Mergifyio rebase will rebase this PR on its base branch
@Mergifyio update will merge the base branch into this PR
@Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

look at your merge queues
generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* refactor #116 remove callback_type Signed-off-by: BrettRD <brettrd@brettrd.com> * rename subscription callback Signed-off-by: BrettRD <brettrd@brettrd.com> * deduplicate remove functions Signed-off-by: BrettRD <brettrd@brettrd.com> (cherry picked from commit 700ea24)

codecov-commenter · 2021-07-28T10:15:49Z

Codecov Report

Merging #163 (8a91037) into galactic (be7c43c) will increase coverage by 0.64%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           galactic     #163      +/-   ##
============================================
+ Coverage     31.31%   31.95%   +0.64%     
============================================
  Files            32       32              
  Lines          3944     3921      -23     
  Branches       1975     1956      -19     
============================================
+ Hits           1235     1253      +18     
+ Misses         1032     1012      -20     
+ Partials       1677     1656      -21

Impacted Files	Coverage Δ
...lc_parameter/src/rclc_parameter/parameter_server.c
...eix1flkawlu/rclc/rclc/test/rclc/test_publisher.cpp
...c/rclc_examples/src/example_executor_convenience.c
...s_ws/src/eix1flkawlu/rclc/rclc/src/rclc/executor.c
ros_ws/src/eix1flkawlu/rclc/rclc/src/rclc/init.c
.../src/eix1flkawlu/rclc/rclc/test/rclc/test_init.cpp
...kawlu/rclc/rclc_examples/src/example_client_node.c
...c_parameter/test/rclc_parameter/test_parameter.cpp
.../rclc/rclc_examples/src/example_parameter_server.c
.../rclc/rclc_examples/src/example_executor_trigger.c
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7c43c...8a91037. Read the comment docs.

* refactor #116 remove callback_type Signed-off-by: BrettRD <brettrd@brettrd.com> * rename subscription callback Signed-off-by: BrettRD <brettrd@brettrd.com> * deduplicate remove functions Signed-off-by: BrettRD <brettrd@brettrd.com> (cherry picked from commit 700ea24) Co-authored-by: Brett Downing <BrettRD@users.noreply.github.com>

* refactor #116 remove callback_type Signed-off-by: BrettRD <brettrd@brettrd.com> * rename subscription callback Signed-off-by: BrettRD <brettrd@brettrd.com> * deduplicate remove functions Signed-off-by: BrettRD <brettrd@brettrd.com> (cherry picked from commit 700ea24) Co-authored-by: Brett Downing <BrettRD@users.noreply.github.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com>

* ci workflow for galactic (#90) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * galactic: updated ci-job and codecov (#91) * bump version to 2.0.1 of galactic branch for new bloom release (#95) * Dummy (#100) * test of galactic bloom release see also #100 (#101) * Adds a context pointer to subscriptions (backport #107) (#120) * Adds a context pointer to subscriptions (#107) (cherry picked from commit 5b11c5a) # Conflicts: # rclc_examples/CMakeLists.txt * resolved merge confict Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Co-authored-by: Brett Downing <BrettRD@users.noreply.github.com> Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> * version bump and updated changelog. (#139) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * prepare bloom release v2.0.3 for galactic (#159) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * refactor #116 remove callback_type (#154) (#163) * refactor #116 remove callback_type Signed-off-by: BrettRD <brettrd@brettrd.com> * rename subscription callback Signed-off-by: BrettRD <brettrd@brettrd.com> * deduplicate remove functions Signed-off-by: BrettRD <brettrd@brettrd.com> (cherry picked from commit 700ea24) Co-authored-by: Brett Downing <BrettRD@users.noreply.github.com> * updated rcl dependency to galactic (#184) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * added pingpong example (#172) (#188) * added pingpong example Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * added two executor configuration to pingpong Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * example_pingpong multiple files Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * added class member function to executor Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> (cherry picked from commit e0252bd) Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> * prepare bloom release 2.0.4-galactic (#193) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * Copy client to action client Initial mods to action client Initial executor support for action client Updates Fix Updates Copy client action to server action Initial action server changes Fix Revert "Copy client to action client" This reverts commit 304c70a. Initial Update Working state Uncrustify fix Update Update Add client Uncrustify Uncrus Apply suggestions from code review Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com> Initial test Fix data available logic Update tests Update Uncrust Revert "Update" This reverts commit 940aa96. Working state Working Building state Update Working state Working state Working state Uncrust Updates Fix cancelling reject Test approach modified Complete server tests Uncrusti Add multigoal test Fix Initial action client tests Add executor client cancel handlers Update action client Add cancel tests Tests update Uncrustify Refactor cancel response handling Update * Revert "Copy client to action client" This reverts commit d65adc7. * Initial version * Hide non public API * Fix abort API * Minor fix * Update * Fix * Add rclcpp dep * Update actions implementation * Delete COLCON_IGNORE * Fix dependencies export * cpplint * Initial Ralph changes Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com> * Add RCLC error * Refactor pop/take inner functions * Argument renaming * Argument renaming * Rename get API to find * Reafctor functio naming * Refactor naming * Remove explicit == true in conditionals * Update rclc/src/rclc/executor.c Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com> * Update rclc/src/rclc/executor.c Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com> * Remove white lines * Update rclc/src/rclc/action_server.c * Apply suggestions from code review Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> * Apply suggestions from code review Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> * Add pointer check suggestions * Apply suggestions on executor * Add check for feedback msg on client * Put goal on default switch case * Revert code delete * Add comments to executor loops * Update loop comments * Apply for loop style where possible * Fix variable name * Fix rebase * ci workflow for galactic (#90) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * galactic: updated ci-job and codecov (#91) Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * bump version to 2.0.1 of galactic branch for new bloom release (#95) Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Dummy (#100) Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * test of galactic bloom release see also #100 (#101) Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Adds a context pointer to subscriptions (backport #107) (#120) * Adds a context pointer to subscriptions (#107) (cherry picked from commit 5b11c5a) # Conflicts: # rclc_examples/CMakeLists.txt * resolved merge confict Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Co-authored-by: Brett Downing <BrettRD@users.noreply.github.com> Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * version bump and updated changelog. (#139) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * prepare bloom release v2.0.3 for galactic (#159) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * refactor #116 remove callback_type (#154) (#163) * refactor #116 remove callback_type Signed-off-by: BrettRD <brettrd@brettrd.com> * rename subscription callback Signed-off-by: BrettRD <brettrd@brettrd.com> * deduplicate remove functions Signed-off-by: BrettRD <brettrd@brettrd.com> (cherry picked from commit 700ea24) Co-authored-by: Brett Downing <BrettRD@users.noreply.github.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * updated rcl dependency to galactic (#184) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * added pingpong example (#172) (#188) * added pingpong example Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * added two executor configuration to pingpong Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * example_pingpong multiple files Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * added class member function to executor Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> (cherry picked from commit e0252bd) Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * prepare bloom release 2.0.4-galactic (#193) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Copy client to action client Initial mods to action client Initial executor support for action client Updates Fix Updates Copy client action to server action Initial action server changes Fix Revert "Copy client to action client" This reverts commit 304c70a. Initial Update Working state Uncrustify fix Update Update Add client Uncrustify Uncrus Apply suggestions from code review Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com> Initial test Fix data available logic Update tests Update Uncrust Revert "Update" This reverts commit 940aa96. Working state Working Building state Update Working state Working state Working state Uncrust Updates Fix cancelling reject Test approach modified Complete server tests Uncrusti Add multigoal test Fix Initial action client tests Add executor client cancel handlers Update action client Add cancel tests Tests update Uncrustify Refactor cancel response handling Update Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Revert "Copy client to action client" This reverts commit d65adc7. Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Initial version Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Hide non public API Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Fix abort API Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Minor fix Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Update Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Fix Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Add rclcpp dep Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Update actions implementation Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Delete COLCON_IGNORE Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Fix dependencies export Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * cpplint Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Initial Ralph changes Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Add RCLC error Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Refactor pop/take inner functions Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Argument renaming Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Argument renaming Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Rename get API to find Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Reafctor functio naming Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Refactor naming Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Remove explicit == true in conditionals Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Update rclc/src/rclc/executor.c Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Update rclc/src/rclc/executor.c Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Remove white lines Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Update rclc/src/rclc/action_server.c Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Apply suggestions from code review Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Apply suggestions from code review Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Add pointer check suggestions Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Apply suggestions on executor Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Add check for feedback msg on client Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Put goal on default switch case Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Revert code delete Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Add comments to executor loops Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Update loop comments Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Apply for loop style where possible Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Fix variable name Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Fix rebase Signed-off-by: Antonio Cuadros <acuadros1995@gmail.com> * Apply suggestions from code review Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> * removed unneccary reset of handle->data_available , in _rclc_check_for_new_data this flag is assigned again. Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * Change put goal function name Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Brett Downing <BrettRD@users.noreply.github.com> Co-authored-by: Antonio Cuadros <acuadros1995@gmail.com> Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com> Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>

mergify bot mentioned this pull request Jul 28, 2021

refactor #116 remove callback_type #154

Merged

JanStaschulat approved these changes Jul 28, 2021

View reviewed changes

JanStaschulat merged commit f8a630c into galactic Jul 28, 2021

JanStaschulat deleted the mergify/bp/galactic/pr-154 branch July 28, 2021 10:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor #116 remove callback_type (backport #154) #163

refactor #116 remove callback_type (backport #154) #163

mergify bot commented Jul 28, 2021

codecov-commenter commented Jul 28, 2021

refactor #116 remove callback_type (backport #154) #163

refactor #116 remove callback_type (backport #154) #163

Conversation

mergify bot commented Jul 28, 2021

codecov-commenter commented Jul 28, 2021

Codecov Report