Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rclc_executor: improve enum type names (backport #379) #383

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 27, 2023

This is an automatic backport of pull request #379 done by Mergify.
Cherry-pick of 14c2c41 has failed:

On branch mergify/bp/humble/pr-379
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 14c2c41.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rclc/src/rclc/executor.c
	modified:   rclc/test/rclc/test_executor.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclc/include/rclc/executor.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 14c2c41)

# Conflicts:
#	rclc/include/rclc/executor.h
@JanStaschulat
Copy link
Contributor

no backport on humble, because additional data structures were only added in Iron and Rolling.
TODO:

  • - update documentation for rclc_executor_semantics_t
  • - improve type names for rclc_executor_semantics_t

@mergify mergify bot deleted the mergify/bp/humble/pr-379 branch June 27, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant