Include original exception in ComponentManagerException #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbuijs
force-pushed
the
print_component_constructor_exception
branch
from
079b66d
to
89275ac
Compare
mjcarroll
approved these changes
Jun 8, 2020
mjcarroll
requested changes
Jun 8, 2020
Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>
mbuijs
force-pushed
the
print_component_constructor_exception
branch
from
89275ac
to
9e76460
Compare
I've clicked the |
fujitatomoya
requested changes
Jun 24, 2020
Co-authored-by: tomoya <Tomoya.Fujita@sony.com> Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>
mbuijs
force-pushed
the
print_component_constructor_exception
branch
from
2322c02
to
668959f
Compare
mjcarroll
approved these changes
Jun 26, 2020
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Jul 7, 2020
* Include original exception in ComponentManagerException Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com> * Update rclcpp_components/src/component_manager.cpp Co-authored-by: tomoya <Tomoya.Fujita@sony.com> Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com> Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
dawonn-haval
pushed a commit
to dawonn-haval/rclcpp
that referenced
this pull request
Jul 10, 2020
* Include original exception in ComponentManagerException Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com> * Update rclcpp_components/src/component_manager.cpp Co-authored-by: tomoya <Tomoya.Fujita@sony.com> Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com> Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
jacobperron
pushed a commit
that referenced
this pull request
Oct 1, 2020
* Include original exception in ComponentManagerException Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com> * Update rclcpp_components/src/component_manager.cpp Co-authored-by: tomoya <Tomoya.Fujita@sony.com> Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com> Co-authored-by: tomoya <Tomoya.Fujita@sony.com> Co-authored-by: Martijn Buijs <Martijn.buijs@gmail.com> Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a component throws an exception in the constructor (e.g. when declaring a parameter) during loading, there's no other feedback than
Component constructor threw an exception. This change introduces a similar construction to what is done earlier in the same file for constructingclass_loader::ClassLoader: try to catchstd::exceptionand append it'swhat()to the newComponentManagerException.