Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract the result response before the callback is issued. #2132

Merged
merged 1 commit into from
Mar 21, 2023
Merged

extract the result response before the callback is issued. #2132

merged 1 commit into from
Mar 21, 2023

Conversation

fujitatomoya
Copy link
Collaborator

address #2130

@fujitatomoya
Copy link
Collaborator Author

@iuhilnehc-ynos can you take a look?

CC: @eschembor-irobot

iuhilnehc-ynos
iuhilnehc-ynos approved these changes Mar 19, 2023
View reviewed changes
Copy link
Collaborator

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion

rclcpp_action/src/client.cpp Outdated Show resolved Hide resolved
@fujitatomoya
extract the result response before the callback is issued.
41de3ac 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/bugfix-rclcpp-issues-2130 branch from 62c6bae to 41de3ac Compare March 20, 2023 20:31
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Mar 20, 2023 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya added a commit that referenced this pull request Mar 20, 2023
@fujitatomoya
extract the result response before the callback is issued.
c2b6925 
  backport of #2132

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chen Lihui <lihui.chen@sony.com>
@fujitatomoya fujitatomoya mentioned this pull request Mar 20, 2023
Merged
@fujitatomoya
Copy link
Collaborator Author

Humble backport is #2133

@fujitatomoya fujitatomoya merged commit bff5992 into rolling Mar 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/bugfix-rclcpp-issues-2130 branch March 21, 2023 21:11
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Mar 24, 2023
@fujitatomoya
extract the result response before the callback is issued. (ros2#2132)
c37589a 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Mar 24, 2023
@fujitatomoya
extract the result response before the callback is issued. (ros2#2132)
eb11591 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this pull request Mar 30, 2023
@fujitatomoya
extract the result response before the callback is issued. (#2133)
c8ac675 
backport of #2132

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chen Lihui <lihui.chen@sony.com>
mergify bot pushed a commit that referenced this pull request Mar 30, 2023
@fujitatomoya @mergify
extract the result response before the callback is issued. (#2133)
9f840e0 
backport of #2132

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chen Lihui <lihui.chen@sony.com>
(cherry picked from commit c8ac675)
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 29, 2023
@fujitatomoya
extract the result response before the callback is issued. (ros2#2132)
48167f0 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 29, 2023
@fujitatomoya
extract the result response before the callback is issued. (ros2#2132)
b9f48f7 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request May 3, 2023
@fujitatomoya
extract the result response before the callback is issued. (ros2#2132)
9722b03 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@SteveMacenski SteveMacenski mentioned this pull request Nov 13, 2023
Open
Barry-Xu-2018 pushed a commit to Barry-Xu-2018/rclcpp that referenced this pull request Jan 12, 2024
@fujitatomoya @Barry-Xu-2018
extract the result response before the callback is issued. (ros2#2132)
ba9561a 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette left review comments

@iuhilnehc-ynos iuhilnehc-ynos iuhilnehc-ynos approved these changes

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fujitatomoya @clalancette @iuhilnehc-ynos