-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract the result response before the callback is issued. #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
March 19, 2023 00:49
@iuhilnehc-ynos can you take a look? |
fujitatomoya
commented
Mar 19, 2023
iuhilnehc-ynos
approved these changes
Mar 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor suggestion
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
fujitatomoya/bugfix-rclcpp-issues-2130
branch
from
March 20, 2023 20:31
62c6bae
to
41de3ac
Compare
fujitatomoya
added a commit
that referenced
this pull request
Mar 20, 2023
backport of #2132 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com>
Humble backport is #2133 |
delete-merged-branch
bot
deleted the
fujitatomoya/bugfix-rclcpp-issues-2130
branch
March 21, 2023 21:11
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Mar 24, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Mar 24, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
added a commit
that referenced
this pull request
Mar 30, 2023
backport of #2132 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rclcpp
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #2130