Fix backport issue bp/jazzy/pr-2556 #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
Barry-Xu-2018
requested review from
fujitatomoya
and removed request for
wjwwood,
hidmic and
ivanpauno
ahcorde
approved these changes
Jul 10, 2024
fujitatomoya
pushed a commit
that referenced
this pull request
Jul 18, 2024
… (#2580) * Release ownership of entities after spinning cancelled (#2556) * Release ownership of entities after spinning cancelled Signed-off-by: Barry Xu <barry.xu@sony.com> * Move release action to every exit point in different spin functions Signed-off-by: Barry Xu <barry.xu@sony.com> * Move wait_result_.reset() before setting spinning to false Signed-off-by: Barry Xu <barry.xu@sony.com> * Update test code Signed-off-by: Barry Xu <barry.xu@sony.com> * Move test code to test_executors.cpp Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit 069a001) # Conflicts: # rclcpp/test/rclcpp/executors/test_executors.cpp * Fix backport issue (#2581) Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com> Co-authored-by: Barry Xu <barry.xu@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #2580