Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nothing uses std_msgs anymore #513

Merged
merged 1 commit into from
Jul 17, 2018
Merged

nothing uses std_msgs anymore #513

merged 1 commit into from
Jul 17, 2018

Conversation

mikaelarguedas
Copy link
Member

To be backported in bouncy ros2/ros2#537

Allows to release the rclcpp repo without needing to release common_interfaces first

Connects to ros2/rcl#270
CI at ros2/rcl#270 (comment)

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jul 13, 2018
@dirk-thomas
Copy link
Member

To be backported in bouncy ros2/ros2#537

Why is this necessary for the Bouncy patch release?

@mikaelarguedas
Copy link
Member Author

Will not be necessary with the requirement of not overlapping repos to variants being dropped for Bouncy ros2/variants#1 (comment)

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jul 14, 2018
@mikaelarguedas mikaelarguedas merged commit 3067a72 into master Jul 17, 2018
@mikaelarguedas mikaelarguedas deleted the use_test_msgs branch July 17, 2018 20:24
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jul 17, 2018
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
…ion (ros2#513)

* add optional rmw payload to rcl options for pub and sub

Signed-off-by: William Woodall <william@osrfoundation.org>

* move ignore_local_publications into rmw options structure for subs

Signed-off-by: William Woodall <william@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants