Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for action server before sending goal #637

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Feb 22, 2019

Wait for discovery before trying to send goal. This is one of the failing tests in ros2/build_farmer#166

See ros2/build_farmer#166 (comment)

CI (testing only rclcpp)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

In progress while CI runs Ready for review

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added bug Something isn't working in progress Actively being worked on (Kanban column) labels Feb 22, 2019
@sloretz sloretz self-assigned this Feb 22, 2019
@sloretz sloretz added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 22, 2019
@sloretz sloretz merged commit 3919ab1 into master Feb 22, 2019
@sloretz sloretz deleted the wait_for_action_server branch February 22, 2019 18:30
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Feb 22, 2019
jacobperron pushed a commit that referenced this pull request Apr 5, 2019
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
jacobperron pushed a commit that referenced this pull request Apr 5, 2019
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
nuclearsandwich pushed a commit that referenced this pull request Apr 5, 2019
Resolves #638

Co-authored-by: Shane Loretz <shane.loretz@gmail.com>
cho3 pushed a commit to cho3/rclcpp that referenced this pull request Jun 3, 2019
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
…n prep for moving it into a separate package (ros2#637)

* Remove rosbag2_compression test dependencies on zstd implementation in prep for moving it into a separate package - by making Fake[De]compressor into a plugin for use by the factory/reader/writer tests

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants