👩🌾 Disable test case that fails consistently on Windows #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
There is a potential resolution for these test failures, but I haven't been able to make progress on it recently. The issue was resolved in foxy with a less-ideal approach. Draft PR: #1404 The test failure represents a memory error, which is not being caught on any other platform, but windows just checks for it with debug builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been failing consistently on Windows debug for a long time (#1282).
See the history here:
https://ci.ros2.org/view/nightly/job/nightly_win_deb/1799/testReport/junit/projectroot.test/rclcpp/test_executors/history/
I suggest disabling that test case until it can be fixed. Otherwise it's just making the build yellow with little benefit.