fixes for rmw callbacks in qos_event class #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
fujitatomoya
approved these changes
Feb 11, 2023
|
https://build.ros2.org/job/Rpr__rclcpp__ubuntu_jammy_amd64/575/ is unrelated failure. i will start the CI. |
|
CI:
|
clalancette
approved these changes
Feb 15, 2023
|
CI:
|
traversaro
pushed a commit
to traversaro/rclcpp
that referenced
this pull request
Feb 16, 2023
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com> Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
alsora
added a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 28, 2023
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
alsora
added a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
alsora
added a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
alsora
added a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
alsora
added a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple of small fixes:
qos_event.hpp. this follows the same logic applied in Fix data race, declare rclcpp callbacks before the rcl entities #2024on_new_event_callback_. theclear_on_ready_callbackalready checks if a callback exists and it does that under a mutex.Signed-off-by: Alberto Soragna alberto.soragna@gmail.com