Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create common structures for executors to use #2143

Merged
merged 25 commits into from
Apr 14, 2023
Merged

Create common structures for executors to use #2143

merged 25 commits into from
Apr 14, 2023

Commits on Mar 29, 2023

  1. Deprecate callback_group call taking context 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2bf88de View commit details
    Browse the repository at this point in the history

  2. Add base executor objects that can be used by implementors 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    9099635 View commit details
    Browse the repository at this point in the history

  3. Template common operations 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2426056 View commit details
    Browse the repository at this point in the history

  4. Address reviewer feedback: 

    * Add callback to EntitiesCollector constructor
* Make function to check automatically added callback groups take a list

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    173ffd6 View commit details
    Browse the repository at this point in the history

  5. Lint 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    a524bf0 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Address reviewer feedback and fix templates 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    89f2106 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'rolling' into mjcarroll/executor_structures

    @mjcarroll
    mjcarroll committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    9695eaa View commit details
    Browse the repository at this point in the history

  3. Lint and docs 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    e173e5a View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Make executor own the notify waitable 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    653d1a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Add pending queue to collector, remove from waitable 

    Also change node's get_guard_condition to return shared_ptr

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    a6c4c1b View commit details
    Browse the repository at this point in the history

  2. Change interrupt guard condition to shared_ptr 

    Check if guard condition is valid before adding it to the waitable

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9dd48ce View commit details
    Browse the repository at this point in the history

  3. Lint and docs 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    6267741 View commit details
    Browse the repository at this point in the history

  4. Don't exchange atomic twice 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    1b1a915 View commit details
    Browse the repository at this point in the history

  5. Fix add_node and add more tests 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    0a9c9a6 View commit details
    Browse the repository at this point in the history

  6. Make get_notify_guard_condition follow API tick-tock 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    0ae0bea View commit details
    Browse the repository at this point in the history

  7. Improve callback group tick-tocking 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    87f41bf View commit details
    Browse the repository at this point in the history

  8. Don't lock twice 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    5809328 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Address reviewer feedback 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    debe396 View commit details
    Browse the repository at this point in the history

  2. Add thread safety annotations and make locks consistent 

    Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
    @mjcarroll
    mjcarroll committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c4b6589 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Address reviewer feedback 

    Signed-off-by: Michael Carroll <michael@openrobotics.org>
    @mjcarroll
    mjcarroll committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    cd7aaba View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Remove the "add_valid_node" API 

    Signed-off-by: Michael Carroll <michael@openrobotics.org>
    @mjcarroll
    mjcarroll committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    6379f0c View commit details
    Browse the repository at this point in the history

  2. Only notify if the trigger condition is valid 

    Signed-off-by: Michael Carroll <michael@openrobotics.org>
    @mjcarroll
    mjcarroll committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    855c64d View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Only trigger if valid and needed 

    Signed-off-by: Michael Carroll <michael@openrobotics.org>
    @mjcarroll
    mjcarroll committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    d9a9206 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'rolling' into mjcarroll/executor_structures

    @mjcarroll
    mjcarroll committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    838d1ae View commit details
    Browse the repository at this point in the history

  3. Merge branch 'rolling' into mjcarroll/executor_structures

    @mjcarroll
    mjcarroll committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ab3bbf4 View commit details
    Browse the repository at this point in the history