[humble] Fix clang warning: bugprone-use-after-move (#2116) #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Passerino <mpasserino@irobot.com> Co-authored-by: Mauro Passerino <mpasserino@irobot.com> Signed-off-by: Tamaki Nishino <otamachan@gmail.com>
otamachan
force-pushed
the
backport-2116-to-humble
branch
from
4fcc2a0
to
ade883d
Compare
fujitatomoya
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
lgtm.
@mauropasse since you are the original author, can we have your review?
|
@alsora Can we get another set of eyes on this one, since it's in the intraprocess manager? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2116 to humble.
Without this, I would need to add
// NOLINT(clang-analyzer-cplusplus.Move)to every mypublish()call in humble.