always check if the service is available, even if the graph event wasn't triggered #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
approved these changes
Oct 28, 2016
wjwwood
force-pushed
the
local_graph_changes
branch
from
3b0ea87
to
41f8793
Compare
wjwwood
force-pushed
the
local_graph_changes
branch
from
41f8793
to
3390a7c
Compare
dhood
reviewed
Oct 29, 2016
| return true; | ||
| } | ||
| event->check_and_clear(); // reset the event | ||
| if (this->service_is_ready()) { // check if the service is ready regardless |
There was a problem hiding this comment.
I think this comment won't be clear once the context of this PR/commit is lost
There was a problem hiding this comment.
regardless of the event state?
There was a problem hiding this comment.
Maybe
// always check if the service is ready, even if the graph event wasn't triggered
// (see https://github.com/ros2/rmw_connext/issues/201)
unless that's then too specific.
There was a problem hiding this comment.
(I know this is captured in the commit message but that can get annoying to track down once the files get moved around)
There was a problem hiding this comment.
For sure, I'm always in favor of more descriptive comments, can you push that change?
Karsten1987
pushed a commit
that referenced
this pull request
Dec 7, 2016
…n't triggered (#262) * always check if the service is available, even if the graph event wasn't triggered * more descriptive comment * Even more descriptive in case the link ever breaks
This was referenced May 22, 2018
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Add badge for license * Add badge for build and test Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to avoid the race condition that is specific to our Connext code, outlined in this issue:
ros2/rmw_connext#201
Basically the assumption "we only need to check the service is available function after a graph event because the state can only change after the graph event is triggered" does not hold. As there is apparently a race between setting the graph event and the underlying state reflecting the full change.
Connects to ros2/rmw_connext#168