Add functions to dump ParameterVariants to json encoded strings #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant> to json encoded strings.
tfoote
added
in progress
wjwwood
changed the title
|
@tfoote what is the status on this ? |
|
These functions were a start toward being able to dump the parameter state to json so that we could easily write unit tests with the expected serialized json result in a file and assert they match. This was deprioritized so this implementation exists but the remainder of the testing capabilities were not implemented to test this. |
|
@tfoote this sounds a bit outdated, can it be closed? |
|
We can close this. There's nothing fundamental or ground breaking in this PR but it's a long way from being feature complete. Hopefully someone might find this and pick up the idea in the future. There are use cases but right now they're not pressing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step toward creating tests which can assert the expected values of parameters in json for easy debugging and comparison.