Waitable should check callback_group if it can be executed. #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
@iuhilnehc-ynos can you help review? |
fujitatomoya
commented
Sep 11, 2022
|
CI:
|
|
a couple of unstable warnings are unrelated. i will go ahead to merge this. |
|
@Mergifyio backport humble galactic foxy |
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 7780fa1) # Conflicts: # rclpy/rclpy/executors.py
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 7780fa1) # Conflicts: # rclpy/rclpy/executors.py
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 7780fa1) # Conflicts: # rclpy/rclpy/executors.py
✅ Backports have been created
|
fujitatomoya
added a commit
that referenced
this pull request
Sep 29, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 7780fa1)
fujitatomoya
added a commit
that referenced
this pull request
Sep 29, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 7780fa1)
fujitatomoya
added a commit
that referenced
this pull request
Sep 29, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 7780fa1)
fujitatomoya
added a commit
that referenced
this pull request
Sep 29, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 7780fa1)
fujitatomoya
added a commit
that referenced
this pull request
Nov 3, 2022
fujitatomoya
added a commit
that referenced
this pull request
Nov 3, 2022
fujitatomoya
added a commit
that referenced
this pull request
Nov 3, 2022
iuhilnehc-ynos
pushed a commit
to iuhilnehc-ynos/rclpy
that referenced
this pull request
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #1000
Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com