add missing error handling and cleanup #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
cleanup-in-error-handling
branch
from
fc44f84
to
cc8fca5
Compare
mjcarroll
approved these changes
Apr 17, 2019
sloretz
added a commit
that referenced
this pull request
Apr 19, 2019
* Every executor gets its own SIGINT guard condition Moves signal handling code to _rclpy_signal_handler Every executor adds a guard condition to a global list SIGINT signal handler triggers all guard conditions in global list Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * _sigint_gc robust to shutdown() called twice Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove redundant comments Comments say the same thing twice. It only needs to be said once. Remove extra comments so the same thing is not repeated. Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Split loop for readability Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * g_guard_conditions atomic variable Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Use rclutils_atomics macros Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Call original handler before losing reference to it Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * remove extra unnecessary assignment Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * g_guard_conditions is a struct on windows Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Rename action state transitions (#300) * Rename action state transitions Now using active verbs as described in the design doc: http://design.ros2.org/articles/actions.html#goal-states Connects to ros2/rcl#399. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * add missing error handling and cleanup (#315) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * Don't store sigint_gc address Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * remove redundant conditional Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Every executor gets its own SIGINT guard condition Moves signal handling code to _rclpy_signal_handler Every executor adds a guard condition to a global list SIGINT signal handler triggers all guard conditions in global list Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * _sigint_gc robust to shutdown() called twice Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove redundant comments Comments say the same thing twice. It only needs to be said once. Remove extra comments so the same thing is not repeated. Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Split loop for readability Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * g_guard_conditions atomic variable Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Use rclutils_atomics macros Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Call original handler before losing reference to it Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * remove extra unnecessary assignment Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * g_guard_conditions is a struct on windows Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Don't store sigint_gc address Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * remove redundant conditional Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found these while debugging something else.