Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send feedback callbacks properly in send_goal() of action client #451

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Send feedback callbacks properly in send_goal() of action client #451

merged 1 commit into from
Nov 21, 2019

Conversation

werner-ne
Copy link
Contributor

Fixes #446

Signed-off-by: Werner Neubauer werner.neubauer@siemens.com

@werner-ne
Send feedback callbacks properly in send_goal() of action client
11a07f8 
Fixes ros2#446

Signed-off-by: Werner Neubauer <werner.neubauer@siemens.com>
sloretz
sloretz approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

jacobperron
jacobperron approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Edit: retriggered (made a typo in the build flags)
Edit: linter warnings are unrelated and fixed on master

@jacobperron jacobperron merged commit 76d26a1 into ros2:master Nov 21, 2019
jacobperron pushed a commit that referenced this pull request Nov 21, 2019
@werner-ne @jacobperron
Send feedback callbacks properly in send_goal() of action client (#451)
670aee5 
Fixes #446

Signed-off-by: Werner Neubauer <werner.neubauer@siemens.com>
@jacobperron jacobperron mentioned this pull request Nov 21, 2019
Merged
jacobperron pushed a commit that referenced this pull request Nov 21, 2019
@werner-ne @jacobperron
Send feedback callbacks properly in send_goal() of action client (#451)
3016917 
Fixes #446

Signed-off-by: Werner Neubauer <werner.neubauer@siemens.com>
@jacobperron jacobperron mentioned this pull request Nov 21, 2019
Merged
jacobperron pushed a commit that referenced this pull request Nov 21, 2019
@werner-ne @jacobperron
Send feedback callbacks properly in send_goal() of action client (#451)
48b2ccb 
Fixes #446

Signed-off-by: Werner Neubauer <werner.neubauer@siemens.com>
@jacobperron jacobperron mentioned this pull request Nov 21, 2019
Merged
jacobperron added a commit that referenced this pull request Nov 25, 2019
@jacobperron
Send feedback callbacks properly in send_goal() of action client (#451)…
6d59221 
… (#465)

Fixes #446

Signed-off-by: Werner Neubauer <werner.neubauer@siemens.com>
jacobperron added a commit that referenced this pull request Nov 25, 2019
@jacobperron
Send feedback callbacks properly in send_goal() of action client (#451)…
4d1f96b 
… (#466)

Fixes #446

Signed-off-by: Werner Neubauer <werner.neubauer@siemens.com>
jacobperron added a commit that referenced this pull request Dec 5, 2019
@jacobperron
Send feedback callbacks properly in send_goal() of action client (#451)…
8e7b686 
… (#467)

Fixes #446

Signed-off-by: Werner Neubauer <werner.neubauer@siemens.com>
suab321321 pushed a commit to suab321321/rclpy that referenced this pull request Jan 31, 2020
@werner-ne @suab321321
Send feedback callbacks properly in send_goal() of action client (ros…
813dfa3 
…2#451)

Fixes ros2#446

Signed-off-by: Werner Neubauer <werner.neubauer@siemens.com>
Signed-off-by: AbhinavSingh <singhabhinav9051571833@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@sloretz sloretz sloretz approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

action client send_goal() must call send_goal_async(goal, kwargs) with **kwargs
3 participants
@werner-ne @jacobperron @sloretz