Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spin_once_until_future_complete to quit when the future finishes. #1143

Merged
merged 3 commits into from
Aug 1, 2023

Commits on Jul 17, 2023

  1. Fix spin_once_until_future_complete to quit when the future finishes.

    This makes it match the function name much more closely.
    While we are in here, also fix a bug where the multi-threaded
    version would not quit immediately after the future completes.
    And also add tests for both of these situations.
    
    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    c938ff4 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Fix from review.

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    93ac361 View commit details
    Browse the repository at this point in the history
  2. Simplify SingleThreadedExecutor _spin_once_impl

    Because we are executing the handler directly, we don't
    need to store it and check for futures later.  We can just
    check the result immediately.
    
    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    fd30442 View commit details
    Browse the repository at this point in the history