Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean qos zenoh tests #1369

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Clean qos zenoh tests #1369

merged 2 commits into from
Oct 11, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 4, 2024

Clean qos zenoh tests.

Related to ros2/rmw_zenoh#286

@ahcorde
Clean qos zenoh tests
b360dee 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from Yadunund October 4, 2024 12:25
@ahcorde ahcorde self-assigned this Oct 4, 2024
@ahcorde ahcorde mentioned this pull request Oct 4, 2024
Open
fujitatomoya
fujitatomoya approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

just a question, those are constraints for now? or zenoh does not have QoS compatibility behavior like DDS?

@ahcorde
make linters happy
bfcb628 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 9, 2024

lgtm with green CI.

just a question, those are constraints for now? or zenoh does not have QoS compatibility behavior like DDS?

@Yadunund can answer this question better than me

@Yadunund
Copy link
Member

Yadunund commented Oct 9, 2024

lgtm with green CI.

just a question, those are constraints for now? or zenoh does not have QoS compatibility behavior like DDS?

QoS with Zenoh does not work the same way as in DDS. Transport will succeed regardless of QoS combinations between pub/subs (in fact publishers do not have QoS settings). So while rmw_zenoh does support IncompatibleQoS events, any registered callbacks will never be triggered. And QoS compatibility check functions will always return favorable compatibility.

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 10, 2024

Pulls: #1369
Gist: https://gist.githubusercontent.com/ahcorde/45d2f6da34fcf22ea1651afc0e7bff9b/raw/520804ec42de689b633266bdf04096a357025e60/ros2.repos
BUILD args: --packages-up-to rclpy --packages-above-and-dependencies rclpy
TEST args: --packages-select rclpy --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14690

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit a09a031 into rolling Oct 11, 2024
3 checks passed
@Yadunund Yadunund deleted the ahcorde/rolling/zenoh_qos branch October 11, 2024 17:49
fujitatomoya added a commit to fujitatomoya/rclpy that referenced this pull request Oct 17, 2024
@fujitatomoya
Revert "Clean qos zenoh tests (ros2#1369)"
e2896aa 
This reverts commit a09a031.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Yadunund Yadunund Awaiting requested review from Yadunund

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @Yadunund @fujitatomoya