Abstract type conversions into functions #269
Merged
Commits on Feb 5, 2019
-
Abstract type conversions into functions
This helps with readability and maintainability. Also eliminated use of assertions during conversions, defering to exceptions. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Commits on Feb 12, 2019
-
Move common C functions to a shared library 'rclpy_common'
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Commits on Feb 13, 2019
-
Do not configure rclpy_common as a cpython extension
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
-
Add symbol visiblity control to satisfy Windows compiler
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
-
Add target_compile_definitions building dll
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.