Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dictionaries raise KeyError #276

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Dictionaries raise KeyError #276

merged 1 commit into from
Feb 19, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Feb 19, 2019

Dictionaries raise KeyError instead of IndexError. I'm not sure how to write a test for this, so I didn't.

See #170 (comment)

@sloretz sloretz added the in review Waiting for review (Kanban column) label Feb 19, 2019
@sloretz sloretz self-assigned this Feb 19, 2019
@sloretz
Copy link
Contributor Author

sloretz commented Feb 19, 2019 •
edited
Loading

CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 9efd331 into master Feb 19, 2019
@sloretz sloretz deleted the cancelled_client_requests branch February 19, 2019 23:03
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloretz @dirk-thomas