Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate set_parameters_callback API #504

Merged
merged 2 commits into from Mar 10, 2020
Merged

Deprecate set_parameters_callback API #504

merged 2 commits into from Mar 10, 2020

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Feb 6, 2020

Resolves #499

Replaced by new API that supports multiple callbacks introduced in #457.
Replaced references to the old API with the new API.
Left tests for the old API that should be removed or updated when we remove
the deprecated API.

CI up to rclpy:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

Replaced by new API that supports multiple callbacks introduced in #457.
Replaced references to the old API with the new API.
Left tests for the old API that should be removed or updated when we remove
the deprecated API.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron self-assigned this Feb 6, 2020
rclpy/rclpy/node.py Outdated Show resolved Hide resolved
@jacobperron jacobperron added this to In progress in Foxy via automation Feb 13, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Foxy automation moved this from In progress to Reviewer approved Mar 6, 2020
hidmic
hidmic approved these changes Mar 6, 2020
Copy link
Contributor

@hidmic hidmic left a comment

LGTM ! You may want to check CI, linters failed back when you ran it.

@jacobperron
Copy link
Member Author

jacobperron commented Mar 6, 2020

Rebuild with latest changes:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (unrelated failures occurring on nightly)

@jacobperron jacobperron merged commit 986c709 into master Mar 10, 2020
1 check passed
Foxy automation moved this from Reviewer approved to Done Mar 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/fix_499 branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Foxy
  
Done
Development

Successfully merging this pull request may close these issues.

2 participants