Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for pre-set and post-set parameter callback. #966

Merged
merged 23 commits into from
Jul 25, 2022
Merged

Support for pre-set and post-set parameter callback. #966

merged 23 commits into from
Jul 25, 2022

Commits on Jul 13, 2022

  1. add support for pre and post param registered callback 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    83920cf View commit details
    Browse the repository at this point in the history

  2. Revert "add support for pre and post param registered callback" 

    This reverts commit 999628b.

Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    cb3d3f0 View commit details
    Browse the repository at this point in the history

  3. add support for pre and post param registered callback 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    5bec0da View commit details
    Browse the repository at this point in the history

  4. add some documentation and testing of pre callback 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    f95d822 View commit details
    Browse the repository at this point in the history

  5. simplify params API 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    049411e View commit details
    Browse the repository at this point in the history

  6. simplify params API 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    2b66e89 View commit details
    Browse the repository at this point in the history

  7. simplify params API 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    b4d300f View commit details
    Browse the repository at this point in the history

  8. added some TODO's 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    38fbb00 View commit details
    Browse the repository at this point in the history

  9. correct refactored API's 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    73b3194 View commit details
    Browse the repository at this point in the history

  10. Remove redundant _set_parameters func 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    3cc949d View commit details
    Browse the repository at this point in the history

  11. _call_pre_set_parameters_callback func 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    7866af9 View commit details
    Browse the repository at this point in the history

  12. return modified list from pre-set param callback 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    76714f6 View commit details
    Browse the repository at this point in the history

  13. pre-set param callback logic change 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    822a6a1 View commit details
    Browse the repository at this point in the history

  14. change function defination of remove_pre_set_param_callback 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    0ad9943 View commit details
    Browse the repository at this point in the history

  15. added unit test for pre_set_param_callback 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    161031b View commit details
    Browse the repository at this point in the history

  16. Add a separate funct for post_set_param handling 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4070088 View commit details
    Browse the repository at this point in the history

  17. added more unit tests for pre set and post set param callback 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    18846e4 View commit details
    Browse the repository at this point in the history

  18. updated documentation of Node API's based on pre and post set param c… 

    …allbacks

Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    3afa6ee View commit details
    Browse the repository at this point in the history

  19. minor change in documentation for set_param API 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4dd60b4 View commit details
    Browse the repository at this point in the history

  20. ament_flake8 and ament_pyflakes 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    ab800cf View commit details
    Browse the repository at this point in the history

  21. ament_pep257 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    d4274e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. update API documentation 

    Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    ddc0b36 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. add unit test for empty pre param callback and made some changes afte… 

    …r CI run failure

Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
    @deepanshubansal01
    deepanshubansal01 committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    37f023f View commit details
    Browse the repository at this point in the history