Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pre-set and post-set parameter callback. #966

Merged
merged 23 commits into from
Jul 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
83920cf
add support for pre and post param registered callback
deepanshubansal01 Jul 11, 2022
cb3d3f0
Revert "add support for pre and post param registered callback"
deepanshubansal01 Jul 11, 2022
5bec0da
add support for pre and post param registered callback
deepanshubansal01 Jul 11, 2022
f95d822
add some documentation and testing of pre callback
deepanshubansal01 Jul 12, 2022
049411e
simplify params API
deepanshubansal01 Jul 12, 2022
2b66e89
simplify params API
deepanshubansal01 Jul 12, 2022
b4d300f
simplify params API
deepanshubansal01 Jul 12, 2022
38fbb00
added some TODO's
deepanshubansal01 Jul 12, 2022
73b3194
correct refactored API's
deepanshubansal01 Jul 12, 2022
3cc949d
Remove redundant _set_parameters func
deepanshubansal01 Jul 12, 2022
7866af9
_call_pre_set_parameters_callback func
deepanshubansal01 Jul 12, 2022
76714f6
return modified list from pre-set param callback
deepanshubansal01 Jul 12, 2022
822a6a1
pre-set param callback logic change
deepanshubansal01 Jul 12, 2022
0ad9943
change function defination of remove_pre_set_param_callback
deepanshubansal01 Jul 12, 2022
161031b
added unit test for pre_set_param_callback
deepanshubansal01 Jul 12, 2022
4070088
Add a separate funct for post_set_param handling
deepanshubansal01 Jul 12, 2022
18846e4
added more unit tests for pre set and post set param callback
deepanshubansal01 Jul 12, 2022
3afa6ee
updated documentation of Node API's based on pre and post set param c…
deepanshubansal01 Jul 12, 2022
4dd60b4
minor change in documentation for set_param API
deepanshubansal01 Jul 13, 2022
ab800cf
ament_flake8 and ament_pyflakes
deepanshubansal01 Jul 13, 2022
d4274e4
ament_pep257
deepanshubansal01 Jul 13, 2022
ddc0b36
update API documentation
deepanshubansal01 Jul 14, 2022
37f023f
add unit test for empty pre param callback and made some changes afte…
deepanshubansal01 Jul 18, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading