Implement join() #20
Merged
Implement join() #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
wjwwood
approved these changes
Sep 4, 2019
include/rcpputils/join.hpp
Outdated
| // Copyright (c) 2019, Open Source Robotics Foundation, Inc. | ||
| // All rights reserved. | ||
| // | ||
| // Software License Agreement (BSD License 2.0) |
There was a problem hiding this comment.
Was this copied from somewhere? Why the BSD License and not Apache 2?
There was a problem hiding this comment.
Oops, that's a bad copy-paste.
There was a problem hiding this comment.
Back to Apache 2 in 1aceb4f.
jacobperron
approved these changes
Sep 4, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests introduces
join(), the inverse ofsplit(). Necessary for ros2/rclcpp#842.