Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for services #2

Closed
1 task done
wjwwood opened this issue Mar 3, 2015 · 2 comments · Fixed by ros2/rosidl#3 or #3
Closed
1 task done

Add support for services #2

wjwwood opened this issue Mar 3, 2015 · 2 comments · Fixed by ros2/rosidl#3 or #3
Assignees
@esteve

Comments

@wjwwood
Copy link
Member

wjwwood commented Mar 3, 2015

Acceptance Criteria:

  • Add service structures and functions to C-API
@wjwwood wjwwood added the ready Work is about to start (Kanban column) label Mar 3, 2015
@esteve esteve added in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels Mar 4, 2015
@wjwwood wjwwood closed this as completed Mar 4, 2015
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label Mar 4, 2015
@wjwwood wjwwood reopened this Mar 4, 2015
@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Mar 4, 2015
@wjwwood
Copy link
Member Author

wjwwood commented Mar 4, 2015

Need to update the ServiceTypeSupportHandle in rosidl_generator_cpp to be something like rosidl_service_type_support_t and modify the rmw/rmw.h functions to take this type.

This was referenced Mar 4, 2015
Merged
Merged
@esteve esteve added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 4, 2015
@wjwwood wjwwood closed this as completed in #3 Mar 4, 2015
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Mar 4, 2015
@wjwwood
Copy link
Member Author

wjwwood commented Mar 4, 2015

Point of process: @esteve, it might be better to avoid things like closes #123 in the associated pull requests since that will close the main issue (like this one) even if all of the pull requests are not merged yet. I think it is still appropriate if it is the only pull request or logically the last pull request.

@oneattosecond oneattosecond mentioned this issue Sep 10, 2019
Closed
mauropasse pushed a commit to mauropasse/rmw that referenced this issue Oct 13, 2020
Merge pull request ros2#2 from mauropasse/mauro-irobot/add-events-exe…
d3b8a9d 
…cutor

Renaming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esteve esteve

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@esteve @wjwwood