fix missing target dependency on rosidl_runtime_c #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
cottsay
approved these changes
Apr 22, 2020
|
CI builds up to rclcpp, testing only the touched packages (for CMake linters):
|
delete-merged-branch
bot
deleted the
dirk-thomas/ament_target_dependencies-interface-keyword
branch
dirk-thomas
commented
Apr 23, 2020
| # since a build dependency for the rosidl_runtime_c targets is undesired | ||
| # they are being added to the rmw interface library here instead | ||
| ament_target_dependencies(rmw::rmw INTERFACE | ||
| rosidl_runtime_c) |
There was a problem hiding this comment.
This isn't compatible with CMake versions < 3.13. See the last bullet in https://cmake.org/cmake/help/v3.16/release/3.13.html#commands (https://cmake.org/cmake/help/v3.16/policy/CMP0079.html).
The error message looks like this:
CMake Error at install/ament_cmake_target_dependencies/share/ament_cmake_target_dependencies/cmake/ament_target_dependencies.cmake:96 (target_link_libraries):
Cannot specify link libraries for target "rmw::rmw" which is not built by
this project.
Depending on what is being built it can happen in different packages:
- in
rmw_connext_shared_cpp(https://ci.ros2.org/job/ci_linux/10450/) - in
rosidl_typesupport_fastrtps_c(e.g. https://ci.ros2.org/job/ci_linux/10455/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ros2/ros2#904.
Needed for
rmw/rmw/include/rmw/rmw.h
Lines 93 to 95 in 21dc0db