Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add build dep on rosidl_runtime_c to work with CMake < 3.13 #221

Merged
merged 2 commits into from
Apr 23, 2020
Merged

add build dep on rosidl_runtime_c to work with CMake < 3.13 #221

merged 2 commits into from
Apr 23, 2020

Conversation

dirk-thomas
Copy link
Member

Fixes #220 (comment)

Bionic builds:

  • Before: Build Status
  • After: Build Status

@dirk-thomas
add build dep on rosidl_runtime_c to work with CMake < 3.13
ae3506e 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added the bug Something isn't working label Apr 23, 2020
@dirk-thomas dirk-thomas self-assigned this Apr 23, 2020
clalancette
clalancette approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for me on Bionic; thanks!

One nit in the comment so we remember that it is CMake 3.13 in the future, but I'll approve anyway.

rmw/package.xml Outdated Show resolved Hide resolved
@dirk-thomas
update comment
496f91e 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas merged commit e2162de into master Apr 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/restore-bionic-comp branch April 23, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@jacobperron jacobperron jacobperron approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dirk-thomas @clalancette @jacobperron