Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rmw] Improve handling of dynamic discovery #338

Merged
merged 31 commits into from
Apr 8, 2023
Merged

[rmw] Improve handling of dynamic discovery #338

merged 31 commits into from
Apr 8, 2023

Commits on Mar 21, 2023

  1. Add types to store user preferences for how discovery works 

    Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
    @gbiggs @wjwwood
    gbiggs authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    3617a59 View commit details
    Browse the repository at this point in the history

  2. Support specification of discovery range and static peers 

    Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
    @gbiggs @wjwwood
    gbiggs authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5cf8a88 View commit details
    Browse the repository at this point in the history

  3. Add an equality tester 

    Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
    @gbiggs @wjwwood
    gbiggs authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    cb43a8c View commit details
    Browse the repository at this point in the history

  4. Small cleanups. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette @wjwwood
    clalancette authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    a493020 View commit details
    Browse the repository at this point in the history

  5. only change const correctness. 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129 @wjwwood
    arjo129 authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e632cca View commit details
    Browse the repository at this point in the history

  6. Add support for dynamic allocation 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129 @wjwwood
    arjo129 authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    02a0550 View commit details
    Browse the repository at this point in the history

  7. Fix equality comparison for discovery params 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    37ffa56 View commit details
    Browse the repository at this point in the history

  8. Fix equality comparison for discovery params 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    231091a View commit details
    Browse the repository at this point in the history

  9. Iterate on struct names 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5ef8a0d View commit details
    Browse the repository at this point in the history

  10. Update function documentation 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    761d1e7 View commit details
    Browse the repository at this point in the history

  11. More params -> parameters 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    678e8a6 View commit details
    Browse the repository at this point in the history

  12. Pass allocators by value instead of by pointer 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1d6c8be View commit details
    Browse the repository at this point in the history

  13. Rename discovery_parameters to discovery_options 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    bb86cd6 View commit details
    Browse the repository at this point in the history

  14. Style tweaks 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    536f613 View commit details
    Browse the repository at this point in the history

  15. Revert to strncpy for now 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0c7b376 View commit details
    Browse the repository at this point in the history

  16. Uncrustify 

    Signed-off-by: Michael X. Grey <grey@openrobotics.org>
    @mxgrey @wjwwood
    mxgrey authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5f35562 View commit details
    Browse the repository at this point in the history

  17. Fix docstrings. 

    Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
    @arjo129 @wjwwood
    arjo129 authored and wjwwood committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e7e1e8d View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Merge branch 'rolling' into gbiggs/discovery-peers-specification

    @sloretz
    sloretz committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    fcc75b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Avoid 'multicast' in comments 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    9e72cec View commit details
    Browse the repository at this point in the history

  2. parameters -> options 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    91beb13 View commit details
    Browse the repository at this point in the history

  3. One sentence per line 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5fc6ce9 View commit details
    Browse the repository at this point in the history

  4. Add rmw_discovery_options_init and tests 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    2cf62e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. const allocator pointer 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    796b6ee View commit details
    Browse the repository at this point in the history

  2. non-const allocator 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    8258369 View commit details
    Browse the repository at this point in the history

  3. Document error if src == dst in copy 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    6086e68 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. SYSTEM_DEFAULT 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    cbd538f View commit details
    Browse the repository at this point in the history

  2. NOT_SET and SYSTEM_DEFAULT values 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    f058084 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. LOCALHOST default in discovery_options_init 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    c6b7949 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. add message about NOT_SET not being valid for rmw to act on 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    2dbd6ef View commit details
    Browse the repository at this point in the history

  2. strncpy_s on windows 

    Signed-off-by: Shane Loretz <sloretz@google.com>
    @sloretz
    sloretz committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    82a22d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Merge branch 'rolling' into gbiggs/discovery-peers-specification

    @sloretz
    sloretz committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b769c85 View commit details
    Browse the repository at this point in the history