Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, the size of an RMW GID should be defined by the RMW
layer and the RMW implementations should conform to it. With
that said, 16 bytes is plenty (and happens to match the size
of a GUID in DDS, which is also 16 bytes). So reduce this
to 16 bytes.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Note that this is a rehash of #328, but I think we have sufficient evidence now that this always should have been 16 bytes. This will also require a PR in rmw_dds_common, which is coming up next.