Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incoherent dissociate_writer to dissociate_reader (#647) #649

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Fix incoherent dissociate_writer to dissociate_reader (#647) #649

merged 1 commit into from
Dec 12, 2022

Conversation

Oscarchoi
Copy link
Contributor

This PR resolves (#647)

Signed-off-by: Wooyoung Choi wy.choi@naverlabs.com

@Oscarchoi
Fix incoherent dissociate_writer to dissociate_reader (ros2#647)
42b03f2 
Signed-off-by: Wooyoung Choi <wy.choi@naverlabs.com>
@Oscarchoi Oscarchoi marked this pull request as ready for review December 10, 2022 05:46
@Oscarchoi
Copy link
Contributor Author

@fujitatomoya It would be appreciated if you would review this PR.

@fujitatomoya
Copy link
Collaborator

@Oscarchoi thanks for the PR.

@fujitatomoya
Copy link
Collaborator

@MiguelCompany Can you do another review on this?

@fujitatomoya fujitatomoya self-assigned this Dec 10, 2022
@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit b56cd5f into ros2:rolling Dec 12, 2022
@fujitatomoya
Copy link
Collaborator

@Mergifyio backport humble foxy

@mergify mergify bot mentioned this pull request Dec 12, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 12, 2022
@Oscarchoi @mergify
Fix incoherent dissociate_writer to dissociate_reader (#647) (#649)
cae7f0f 
Signed-off-by: Wooyoung Choi <wy.choi@naverlabs.com>
(cherry picked from commit b56cd5f)
@mergify mergify bot mentioned this pull request Dec 12, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 12, 2022
@Oscarchoi @mergify
Fix incoherent dissociate_writer to dissociate_reader (#647) (#649)
d79e9df 
Signed-off-by: Wooyoung Choi <wy.choi@naverlabs.com>
(cherry picked from commit b56cd5f)

# Conflicts:
#	rmw_fastrtps_shared_cpp/src/rmw_subscription.cpp
@mergify
Copy link

mergify bot commented Dec 12, 2022

backport humble foxy

✅ Backports have been created

fujitatomoya pushed a commit that referenced this pull request Dec 12, 2022
@Oscarchoi @fujitatomoya
Fix incoherent dissociate_writer to dissociate_reader (#647) (#649)
bb15220 
Signed-off-by: Wooyoung Choi <wy.choi@naverlabs.com>
(cherry picked from commit b56cd5f)
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@Oscarchoi Oscarchoi deleted the bugfix/fix-incohernet-dissociate-reader branch December 13, 2022 05:51
quarkytale pushed a commit that referenced this pull request May 17, 2023
@mergify @Oscarchoi
Fix incoherent dissociate_writer to dissociate_reader (#647) (#649) (#…
4eba2ba 
…652)

(cherry picked from commit b56cd5f)

Signed-off-by: Wooyoung Choi <wy.choi@naverlabs.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Oscarchoi <wychoi502@gmail.com>
@clalancette clalancette mentioned this pull request Jun 13, 2023
Closed
fujitatomoya pushed a commit that referenced this pull request Sep 5, 2023
@Oscarchoi @fujitatomoya
Fix incoherent dissociate_writer to dissociate_reader (#647) (#649)
9a737dc 
Signed-off-by: Wooyoung Choi <wy.choi@naverlabs.com>
(cherry picked from commit b56cd5f)
fujitatomoya pushed a commit that referenced this pull request Sep 5, 2023
@mergify @Oscarchoi
Fix incoherent dissociate_writer to dissociate_reader (#647) (#649) (#…
79f23ae 
…651)

Signed-off-by: Wooyoung Choi <wy.choi@naverlabs.com>
(cherry picked from commit b56cd5f)

Co-authored-by: Oscarchoi <wychoi502@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Oscarchoi @fujitatomoya @MiguelCompany