Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove topic partitions #192

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Remove topic partitions #192

merged 3 commits into from
Jun 7, 2018

Commits on May 14, 2018

  1. removed the use of partitions, use the complete topic_name directly 

    Removed assign_partitions.hpp header

trial: removal of topic partitions from services and client

Modified readerinfo, writerinfo and added prefix to the topic names.
    @rohitsalem @Karsten1987
    rohitsalem authored and Karsten1987 committed May 14, 2018
    Configuration menu
    Copy the full SHA
    1eec70a View commit details
    Browse the repository at this point in the history

  2. Changed topic namespacing in services and clients 

    minor style changes

Delete assign_partitions.hpp and removed anything related to partitons

re-adding avoid_ros_namespace_conventions check for prefixing names

Corrected indentation

Added vertical space between the headers
    @rohitsalem @Karsten1987
    rohitsalem authored and Karsten1987 committed May 14, 2018
    Configuration menu
    Copy the full SHA
    96a401b View commit details
    Browse the repository at this point in the history

  3. remove unnecessary initializations

    @rohitsalem @Karsten1987
    rohitsalem authored and Karsten1987 committed May 14, 2018
    Configuration menu
    Copy the full SHA
    ec44260 View commit details
    Browse the repository at this point in the history